[Client] Java client #198

mahatoankitkumar · 2024-08-05T11:29:33Z

Problem

Java CAC Client

ayushjain17 · 2024-08-12T10:55:53Z

clients/java/src/main/java/CAC/ExperimentationClient.java

we keep the two clients separately in different projects

Datron · 2024-08-26T10:34:00Z

clients/java/exp-client/gradle/libs.versions.toml

+# https://docs.gradle.org/current/userguide/platforms.html#sub::toml-dependencies-format
+
+[versions]
+guava = "33.1.0-jre"


Why do we import guava? Do we need this?

Not sure, let me check.

Datron · 2024-08-26T10:35:48Z

clients/java/README.md

+# JAVA Client
+
+## Prerequisites
+
+- Java JDK
+- Gradle 7.0 or later
+
+## Building the Project
+
+To build the project, run:
+```
+./gradlew build
+```
+


Can we add documentation on how to add this to a separate project?

Datron · 2024-08-26T10:36:18Z

clients/java/cac-client/gradle/libs.versions.toml

+guava = "33.1.0-jre"
+junit-jupiter = "5.10.2"
+
+[libraries]
+guava = { module = "com.google.guava:guava", version.ref = "guava" }
+junit-jupiter = { module = "org.junit.jupiter:junit-jupiter", version.ref = "junit-jupiter" }


Why do we need these libraries?

Datron · 2024-08-26T10:38:32Z

clients/java/cac-client/src/main/java/CAC/CacClient.java

+    public static RustLib rustLib;
+
+    public CacClient(String libraryPath, String libraryName) {
+        System.setProperty("jnr.ffi.library.path", libraryPath);


Read library path from ENV
SUPERPOSITION_LIB_PATH

Datron · 2024-08-26T10:39:20Z

clients/java/cac-client/src/main/java/CAC/CacClient.java

+        int result = rustLib.cac_new_client(tenant, updateFrequency, hostName);
+        if (result > 0) {
+            String errorMessage = rustLib.cac_last_error_message();
+            throw new IOException("Failed to create new CAC client: " + errorMessage);


This is not an IOException right? Can we create a special Exception object for this?

Datron · 2024-08-26T11:24:52Z

clients/java/cac-client/src/main/java/CAC/CacClient.java

+        if (ptr == null) {
+            return null;
+        }
+        try {
+            return ptr.getString(0);
+        } finally {
+            freeString(ptr);
+        }
+    }


Can we write this better?

Doesn't it looks fine?

Datron · 2024-08-26T11:25:57Z

clients/java/cac-client/src/main/java/CAC/Client.java

+    private static void callCacClient() {
+        String dylib = "cac_client";
+        File currentDir = new File(System.getProperty("user.dir"));
+        String libraryPath = currentDir.getParentFile().getParentFile().getParentFile() + "/target/debug";


No hardcoding the path please, use env SUPERPOSITION_LIB_PATH

Datron · 2024-08-26T11:26:24Z

clients/java/cac-client/src/main/java/CAC/Client.java

+
+        int newClient;
+        try {
+            newClient = wrapper.cacNewClient(tenant, 1, "http://localhost:8080");


The URL should not be hardcoded, is this an example file?

Yes this is an example file.

Datron · 2024-08-26T11:27:13Z

clients/java/cac-client/src/main/java/CAC/Client.java

+
+import jnr.ffi.Pointer;
+
+public class Client {


Can we name this class better? It seems like a Client implementation

Datron · 2024-08-26T11:28:03Z

clients/java/exp-client/src/main/java/CAC/Client.java

@@ -0,0 +1,116 @@
+package CAC;


Package should be different

Datron · 2024-08-26T12:38:21Z

Can you add java and gradle versions in flakes.nix as well?

* feat: java client * fix: Removed unnecessary files * fix: more cleanups * feat: Add expt client wrapper * fix: add experiment client implementation * fix: Added README.md * fix: separated cac-client and exp-client * fix: separated cac-client and exp-client * fix: make it a lib * fix: Added Readme.md to use the clients * fix: yaml file --------- Co-authored-by: Ankit Mahato <[email protected]>

mahatoankitkumar requested a review from a team as a code owner August 5, 2024 11:29

mahatoankitkumar force-pushed the feat/java-client branch 3 times, most recently from 448fb73 to 58b53c5 Compare August 7, 2024 11:07

mahatoankitkumar changed the title ~~feat: java client~~ [Client]: java client Aug 7, 2024

mahatoankitkumar changed the title ~~[Client]: java client~~ [Client] Java client Aug 7, 2024

ayushjain17 reviewed Aug 12, 2024

View reviewed changes

clients/java/src/main/java/CAC/ExperimentationClient.java Outdated

Copy link

Collaborator

ayushjain17 Aug 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we keep the two clients separately in different projects

mahatoankitkumar requested a review from ayushjain17 August 12, 2024 11:45

Datron reviewed Aug 26, 2024

View reviewed changes

Datron requested changes Aug 26, 2024

View reviewed changes

mahatoankitkumar force-pushed the feat/java-client branch from 65d78a4 to 9df9c7f Compare August 29, 2024 11:34

Datron force-pushed the main branch 8 times, most recently from 6ca353c to 41073fc Compare September 2, 2024 10:08

mahatoankitkumar requested a review from Datron September 2, 2024 12:24

mahatoankitkumar force-pushed the feat/java-client branch 9 times, most recently from fb9f0ad to 7c87aa6 Compare September 3, 2024 12:59

mahatoankitkumar force-pushed the feat/java-client branch 4 times, most recently from 35e61af to fd5c309 Compare September 3, 2024 13:47

Datron force-pushed the feat/java-client branch 4 times, most recently from 1355e99 to a8c218d Compare September 4, 2024 06:12

Datron approved these changes Sep 4, 2024

View reviewed changes

mahatoankitkumar force-pushed the feat/java-client branch 2 times, most recently from 469448f to f24abe8 Compare September 4, 2024 06:39

Ankit Mahato added 10 commits September 4, 2024 12:26

feat: java client

3fcec85

fix: Removed unnecessary files

64ad8cd

fix: more cleanups

558a6b3

feat: Add expt client wrapper

b5839f0

fix: add experiment client implementation

80fbd04

fix: Added README.md

174eede

fix: separated cac-client and exp-client

9366013

fix: separated cac-client and exp-client

220bd0a

fix: make it a lib

fc941e8

fix: Added Readme.md to use the clients

1c4f269

mahatoankitkumar force-pushed the feat/java-client branch 2 times, most recently from 4ac0f1a to 2599c16 Compare September 4, 2024 08:36

fix: yaml file

6a73495

mahatoankitkumar force-pushed the feat/java-client branch from 2599c16 to 6a73495 Compare September 4, 2024 08:43

ShubhranshuSanjeev approved these changes Sep 4, 2024

View reviewed changes

mahatoankitkumar merged commit 8735883 into main Sep 4, 2024
4 checks passed

mahatoankitkumar deleted the feat/java-client branch September 4, 2024 09:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Client] Java client #198

[Client] Java client #198

mahatoankitkumar commented Aug 5, 2024

ayushjain17 Aug 12, 2024

Datron Aug 26, 2024

mahatoankitkumar Aug 26, 2024

Datron Aug 26, 2024

Datron Aug 26, 2024

mahatoankitkumar Aug 26, 2024

Datron Aug 26, 2024

Datron Aug 26, 2024

Datron Aug 26, 2024

mahatoankitkumar Aug 26, 2024

Datron Aug 26, 2024

Datron Aug 26, 2024

mahatoankitkumar Aug 26, 2024

Datron Aug 26, 2024

Datron Aug 26, 2024

Datron commented Aug 26, 2024

[Client] Java client #198

[Client] Java client #198

Conversation

mahatoankitkumar commented Aug 5, 2024

Problem

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Datron commented Aug 26, 2024