Feat/webhook cruds #313
Open
Feat/webhook cruds #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahatoankitkumar
force-pushed
the
feat/webhook-cruds
branch
2 times, most recently
from
e1ce6e0 to
2ef5451
Compare
Datron
reviewed
Dec 17, 2024
| @@ -0,0 +1,238 @@ | |||
| use actix_web::{ | |||
There was a problem hiding this comment.
@mahatoankitkumar I don't think this should sit in CAC as its used across all crates. You should move webhooks code to superposition crate
Datron
reviewed
Dec 17, 2024
Datron
reviewed
Dec 17, 2024
Datron
reviewed
Dec 17, 2024
mahatoankitkumar
force-pushed
the
feat/webhook-cruds
branch
from
2ef5451 to
8e9936c
Compare
* feat: Add auth via OAUTH2 * feat: Make auth endpoints part of AuthHandler
mahatoankitkumar
force-pushed
the
feat/webhook-cruds
branch
from
8e9936c to
2018276
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Webhook Crud
Post-deployment activity
Change the execute_webhook_call to take webhooks from the table instead of tenant_config.