fix: add unique position contraint as deferred #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahatoankitkumar
requested changes
Jan 2, 2025
| ADD CONSTRAINT dimension_unique_position UNIQUE (position) DEFERRABLE INITIALLY IMMEDIATE; |
There was a problem hiding this comment.
Guess you can make a new migration file for this one?
There was a problem hiding this comment.
@mahatoankitkumar no need to make a new migration for this , its just a minor upgradation in the constraint
sauraww
approved these changes
Jan 2, 2025
pratikmishra356
force-pushed
the
position-db-fix
branch
from
5b8a710 to
786ed1f
Compare
mahatoankitkumar
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
During position update statement , we increment/decrement the values , which conflicts with the unique constraint within the transaction
Solution
Making constraint as deferred which validates on transaction commit instead of statement
Environment variable changes
What ENVs need to be added or changed
Pre-deployment activity
Things needed to be done before deploying this change (if any)
Post-deployment activity
Things needed to be done after deploying this change (if any)
API changes
Possible Issues in the future
Describe any possible issues that could occur because of this change