feat: added description and comment (#284) #344
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datron
approved these changes
Jan 17, 2025
| let last_modified_time = Utc::now().naive_utc(); | ||
| let config_version_id = | ||
| conn.transaction::<_, superposition::AppError, _>(|transaction_conn| { | ||
| for (context_weight, context_id) in contexts_new_weight { | ||
| for (context_weight, context_id, _description, _change_reason) in contexts_new_weight.clone() { |
There was a problem hiding this comment.
Why _description and _change_reason? Are we not using these variables anywhere?
| @@ -87,6 +112,7 @@ async fn update_type( | |||
| type_templates::type_schema.eq(request.clone()), | |||
There was a problem hiding this comment.
Hey so there is an issue here. Request now contains description and change reason, which cannot directly be inserted into the column type_schema. We need to extract type schema. It would be better to create a type TypeTemplateUpdateRequest. This can be taken from org__id-test branch, or when we rebase we can keep that code
|
Closing this PR, the commit is there in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Describe the problem you are trying to solve here
Solution
Provide a brief summary of your solution so that reviewers can understand your code
Environment variable changes
What ENVs need to be added or changed
Pre-deployment activity
Things needed to be done before deploying this change (if any)
Post-deployment activity
Things needed to be done after deploying this change (if any)
API changes
Possible Issues in the future
Describe any possible issues that could occur because of this change