Skip to content

Commit

Permalink
updated the warning message after disabling ads
Browse files Browse the repository at this point in the history
  • Loading branch information
jwallet committed Aug 25, 2019
1 parent cbee9a4 commit d7aad2b
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 14 deletions.
2 changes: 1 addition & 1 deletion EspionSpotify/Translations/en.Designer.cs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion EspionSpotify/Translations/en.resx
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,7 @@
<comment>message</comment>
</data>
<data name="msgBodyDisableAds" xml:space="preserve">
<value>By disabling ads, you also disable Spotify radios, your daily mixes, podcasts and your friend list. Otherwise, Spotify could still be able to play some ads. Disable this feature before leaving Spytify if you want to recover all these Spotify features.</value>
<value>By disabling ads, you will block ads coming from partners (third parties domains). Spotify will still be able to play their own ads, because they come from the same domain that their music content, radio, friends list and daily mix.</value>
<comment>interface</comment>
</data>
<data name="msgTitleDisableAds" xml:space="preserve">
Expand Down
2 changes: 1 addition & 1 deletion EspionSpotify/Translations/fr.Designer.cs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions EspionSpotify/Translations/fr.resx
Original file line number Diff line number Diff line change
Expand Up @@ -386,8 +386,8 @@
<comment>console</comment>
</data>
<data name="msgBodyDisableAds" xml:space="preserve">
<value>En désactivant les annonces, vous désactivez aussi les radios Spotify, vos mixes journaliers, les podcasts et votre liste d'amis. Autrement, Spotify serait encore capable de jouer des annonces. Désactiver cette fonctionnalité avant de quitter Spytify si vous voulez rétablir toutes ces fonctionnalités de Spotify.</value>
<comment>interface</comment>
<value>En désactivant les annonces, vous bloquerez les annonces provenant de partenaires (domaines tiers). Spotify pourra quand même jouer leurs propre annonces, puisqu'elles viennent du même domaine que leur contenu musical, radio, liste d'amis et "daily mix".</value>
<comment>message</comment>
</data>
<data name="msgTitleDisableAds" xml:space="preserve">
<value>Désactiver les annonces</value>
Expand Down
14 changes: 5 additions & 9 deletions EspionSpotify/frmEspionSpotify.cs
Original file line number Diff line number Diff line change
Expand Up @@ -467,15 +467,11 @@ private void TgDisableAds_Click(object sender, EventArgs e)

if (Administrator.EnsureAdmin())
{
// Recover friend list, radios, podcasts, daily mixes : spclient.wg.spotify.com (removed in 1.1.4)

// TODO: If a new way comes back to block more ads, we may have to
// valid that it still doesn't block these Spotify features.
// if (tgDisableAds.Checked && MetroMessageBox.Show(this,
// Rm.GetString($"msgBodyDisableAds"),
// Rm.GetString($"msgTitleDisableAds"),
// MessageBoxButtons.OK,
// MessageBoxIcon.Question) == DialogResult.OK) return;
if (tgDisableAds.Checked && MetroMessageBox.Show(this,
Rm.GetString($"msgBodyDisableAds"),
Rm.GetString($"msgTitleDisableAds"),
MessageBoxButtons.OK,
MessageBoxIcon.Question) == DialogResult.OK) return;
return;
}

Expand Down

0 comments on commit d7aad2b

Please sign in to comment.