Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate the genre column #238

Merged
merged 1 commit into from
Feb 24, 2020

Conversation

samuele-mattiuzzo
Copy link
Contributor

@samuele-mattiuzzo samuele-mattiuzzo commented Feb 23, 2020

  • Replace all the scattered genres and sub genres with <main genre>/<sub-genre>

  • Retained alphabetical order for sub-genres

  • When a movie has mixed main-genres tags, alphabetical order is retained

  • I have carefully read and comply with the Contributing Guidelines of this repo.

  • I have searched the PRs of this repo and believe that this is not a duplicate.

Refs: #236

- Replace all the scattered genres and sub genres with <main genre>/<sub-genre>
- Retained alphabetical order for sub-genres
- When a movie has mixed main-genres tags, alphabetical order is retained
Copy link
Owner

@k4m4 k4m4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@k4m4 k4m4 merged commit 77aa259 into k4m4:master Feb 24, 2020
@samuele-mattiuzzo
Copy link
Contributor Author

Thank you!

@samuele-mattiuzzo samuele-mattiuzzo deleted the samuele-mattiuzzo-patch-2 branch February 25, 2020 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants