remove emoticons option #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Nowadays, messages can contain both unicode emoji and text smileys. - This extension/options doesn't bring a real added value IMO. Moreover it had to be enabled by the user to be effectiv to be effective - the emoticons js scripts contained pictures licensed under CC-BY-SA-2.5 which is not DFSG compatible. See: https://wiki.debian.org/DFSGLicenses#Creative_Commons_Attribution-ShareAlike_3.0_Unported_.28CC_BY-SA_3.0.29 - CI3 has a Smiley plugin which does an equivalent job and is marked as deprecated https://codeigniter.com/userguide3/helpers/smiley_helper.html
tenzap
force-pushed
the
feature-201-remove-emoticons
branch
from
eeba8ea to
456d8af
Compare
|
@kingster, What about this one? Missed it? |
kingster
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nowadays, messages can contain both unicode emoji and text smileys.
This extension/options doesn't bring a real added value IMO. Moreover it had to be enabled by the user to be effective
the emoticons js scripts contained pictures licensed under CC-BY-SA-2.5 which is not DFSG compatible. See:
https://wiki.debian.org/DFSGLicenses#Creative_Commons_Attribution-ShareAlike_3.0_Unported_.28CC_BY-SA_3.0.29
CI3 has a Smiley plugin which does an equivalent job and is marked as deprecated https://codeigniter.com/userguide3/helpers/smiley_helper.html