check libnccl instead of nccl to be more reliable #742
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grep nccl
may not be a reliable way to check if nccl is installed;for example, on my workstation:
shows
and the Makefile mistakenly thinks that I have nccl installed, and then tries to link nccl, and then failed.
So changing it to
grep libnccl
to be slightly more reliable; I installed nccl, and then verified thatshows