Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

kata-webhook: update dependencies #5804

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Conversation

arc9693
Copy link
Contributor

@arc9693 arc9693 commented Dec 22, 2023

Summary

  • This change was required because an outdated dependency of katawebhook removes gRPC handler from spec during mutation review, intended to only add runtimeClass name to spec
  • This commit aims at updating katawebhook dependency from v2.1.0 -> v2.5.0, to support newer versions of k8s, which in turn updates other dependencies.
  • The go version in go.mod of kata-webhook is updated from v1.16 -> v1.21, and there is a corresponding change in Dockerfile.

Fixes: kata-containers/kata-containers#7565

Signed-off-by: Archana Choudhary [email protected]

@katacontainersbot katacontainersbot added the size/huge Largest and most complex task (probably needs breaking into small pieces) label Dec 22, 2023
Copy link
Member

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @arc9693!

@fidencio
Copy link
Member

fidencio commented Jan 8, 2024

@arc9693, you're missing the Signed-off-by in your commit and our CI is not happy about that.
https://wiki.linuxfoundation.org/dco

@arc9693
Copy link
Contributor Author

arc9693 commented Jan 8, 2024

@arc9693, you're missing the Signed-off-by in your commit and our CI is not happy about that. https://wiki.linuxfoundation.org/dco

Updated.

@arc9693 arc9693 force-pushed the main branch 2 times, most recently from 1e449bf to ca1ada2 Compare January 8, 2024 14:27
This commit aims at updating katawebhook dependency from v2.1.0 -> v2.5.0,
 to support newer versions of k8s, which in turn updates other dependencies.

The go version is updated from v1.16 -> v1.21, and there is a corresponding
 change in Dockerfile.

Fixes: github.com/kata-containers/kata-containers#7565

Signed-off-by: Archana Choudhary <[email protected]>
@danmihai1
Copy link
Member

/test

@fidencio fidencio merged commit da8b88d into kata-containers:main Jan 9, 2024
9 checks passed
@ldoktor
Copy link
Contributor

ldoktor commented Jan 16, 2024

@arc9693 thank you, I have tested this by pushing this image to docker.io/ldoktor/kata-webhook-example:latest and it does address this image. @fidencio could you please push this image to quay (or do you know who has the write access there?) I'll then re-enable those tests in the CI.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/huge Largest and most complex task (probably needs breaking into small pieces)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

e2e: [sig-node] Probing container should be restarted with a GRPC liveness probe
6 participants