-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HyelaLee - Final Revise #14
Open
githubhyelalee
wants to merge
102
commits into
kcc-nma-art249:master
Choose a base branch
from
githubhyelalee:gh-pages
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
textoutine wasn’t work for firefox, so I updated code that works for all browsers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@epilande Hi Manny,
Most of parts are done.
Jusr two issues I need to be done:
1. Responsive slider for Section02,04,05____
I tried this link said:
But nothing happend:
And I tried give width: 100% for thumnails which still not working.
Section02,04,05 are all looks different in mobile view, so probably different code for each sections.
2. Page override_____________
Like before we talked about, page override is too fast, user can't see the bottom of the page when they scrolling.
Please let me know if you figure it out when you have a chance. Thank you!
Happy holiday! :):):):):):)