add tests for special characters and pipecomment #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Two tests have been added to account for issue 722 and issue 753. Minor linting issues with flake8 have also been fixed.
test_special_charstests a multiline SQL statement which contains special characters, newlines, double quotes, comparison operators and concatenation. It expects three separate statements.test_split_pipe_commentstests an SQL statement which does not have a space between the | and -- (pipe and comment). It expects one statement given that everything after the -- is part of the comment, but currently fails unless a space is added between the pipe and comment.Tests Results