Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated leaderboard(yaten2302) for issue #2068 #33

Merged
merged 1 commit into from
Aug 26, 2024
Merged

updated leaderboard(yaten2302) for issue #2068 #33

merged 1 commit into from
Aug 26, 2024

Conversation

yaten2302
Copy link
Contributor

This PR adds points for a new issue (revamp of keploy's navbar) - keploy/keploy#2068

@nehagup nehagup requested a review from Sonichigo August 5, 2024 10:33
@TvisharajiK
Copy link

Hey @yaten2302

Really liked your design. Had a couple of suggestions though.

  1. The font and the image size is too so it looks a little out of place
Screenshot 2024-08-22 at 5 52 43 PM
  1. This is not aligned well since the colors are not even both the sides
Screenshot 2024-08-22 at 5 53 49 PM
  1. It greys out on hovering which doesn't highlight the text well

These were some suggestions from my end, I have tried to make a design file that you can try to implement on top of this. The rest actually looks pretty great.

Screenshot 2024-08-22 at 5 56 41 PM

You can let me know if you want to take this up, I will share the figma file to you. We need a open source and enterprise tab with the brand color on hover. The border radius should also remain consistent throughout

@yaten2302
Copy link
Contributor Author

Hey @TvisharajiK , thanks for your suggestions!! The changes you suggested are great!
I would like to take this up 👍
Could you please share the figma link. Actually, I'm currently learning about designing and prototyping in figma, so that's why I was able to make this only as the final one 😅

@yaten2302
Copy link
Contributor Author

Also, should I close this PR and then create a new one instead?

@Sonichigo Sonichigo merged commit 2db4323 into keploy:main Aug 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants