Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: Bump checkup base image #239

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

RamLavi
Copy link
Collaborator

@RamLavi RamLavi commented Aug 12, 2024

No description provided.

@RamLavi RamLavi requested a review from orelmisan August 12, 2024 11:27
@RamLavi
Copy link
Collaborator Author

RamLavi commented Aug 12, 2024

@RamLavi RamLavi force-pushed the bump-base-image_9.4-1181 branch from 6dc95e3 to 774c05d Compare August 12, 2024 13:29
@RamLavi
Copy link
Collaborator Author

RamLavi commented Aug 12, 2024

@orelmisan
Copy link
Member

We use ubi 9 minimal:

FROM registry.access.redhat.com/ubi9/ubi-minimal:$BASE_IMAGE_TAG

https://catalog.redhat.com/software/containers/ubi9/ubi-minimal/615bd9b4075b022acc111bf5

Copy link
Member

@orelmisan orelmisan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @RamLavi.
Please run it e2e before merging the PR.

@RamLavi
Copy link
Collaborator Author

RamLavi commented Aug 15, 2024

Passed CI on 4.17 cluster with same node topology.

make test/e2e
podman run --rm \
           --volume /home/ralavi/go/src/github.com/kiagnose/kubevirt-dpdk-checkup:/home/ralavi/go/src/github.com/kiagnose/kubevirt-dpdk-checkup:Z \
           --volume /home/ralavi/Downloads:/root/.kube:Z,ro \
           --workdir /home/ralavi/go/src/github.com/kiagnose/kubevirt-dpdk-checkup \
           -e KUBECONFIG=/root/.kube/bm02-ibm-kubeconfig \
           -e TEST_CHECKUP_IMAGE=quay.io/ramlavi/kubevirt-dpdk-checkup:latest \
           -e TEST_NAMESPACE=dpdk-checkup-ns \
           -e NETWORK_ATTACHMENT_DEFINITION_NAME=dpdk-sriovnetwork \
           -e TRAFFIC_GEN_CONTAINER_DISK_IMAGE=quay.io/kiagnose/kubevirt-dpdk-checkup-traffic-gen:main \
           -e VM_UNDER_TEST_CONTAINER_DISK_IMAGE=quay.io/kiagnose/kubevirt-dpdk-checkup-vm:main \
           docker.io/library/golang:1.20.12 go test ./tests/... -test.v -test.timeout=1h -ginkgo.v -ginkgo.timeout=1h
=== RUN   TestKubevirtDpdkCheckup
Running Suite: KubevirtDpdkCheckup Suite - /home/ralavi/go/src/github.com/kiagnose/kubevirt-dpdk-checkup/tests
==============================================================================================================
Random Seed: 1723708035

Will run 1 of 1 specs
------------------------------
[BeforeSuite] 
/home/ralavi/go/src/github.com/kiagnose/kubevirt-dpdk-checkup/tests/test_suite_test.go:56
[BeforeSuite] PASSED [0.003 seconds]
------------------------------
Execute the checkup Job should complete successfully
/home/ralavi/go/src/github.com/kiagnose/kubevirt-dpdk-checkup/tests/checkup_test.go:83
• [223.273 seconds]
------------------------------

Ran 1 of 1 Specs in 223.276 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestKubevirtDpdkCheckup (223.28s)
PASS
ok  	github.com/kiagnose/kubevirt-dpdk-checkup/tests	223.301s

@RamLavi RamLavi merged commit 7be4ed9 into kiagnose:main Aug 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants