Preserve fragments in URLs #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This turns out to not be a complete fix. The |
When URLs have fragments in them, pushy used to discard them. This change
preserves the fragment. Example:
<a href="/a-page#some-header">
Pushy would go to just "/a-page" before this change.
magnars
force-pushed
the
preserve-fragments-in-urls
branch
from
30e537b to
f7e7d13
Compare
|
Thankfully it wasn't goog.History that omitted the initial hash, so I was able to mend this easily enough. This PR is now good again. :) |
This was referenced Aug 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When URLs have fragments in them, pushy used to discard them. This change
preserves the fragment. Example:
Pushy would go to just
/a-pagebefore this change.