Skip to content

Commit

Permalink
fix: min max zoom arg doc and doc building (#1523)
Browse files Browse the repository at this point in the history
Co-authored-by: theodu <[email protected]>
  • Loading branch information
2 people authored and Jonas1312 committed Oct 9, 2023
1 parent c9b50f4 commit ac650a8
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 12 deletions.
26 changes: 19 additions & 7 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,22 +9,22 @@ jobs:
- uses: actions/setup-python@v4
with:
python-version: 3.8
cache: 'pip'
cache: "pip"
- uses: pre-commit/[email protected]

pylint:
runs-on: ubuntu-latest
name: Pylint test
strategy:
matrix:
python-version: ['3.8', '3.11']
python-version: ["3.8", "3.11"]
steps:
- uses: actions/checkout@v4
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python-version }}
cache: 'pip'
cache: "pip"
- name: Install dependencies
run: |
python -m pip install --upgrade pip
Expand All @@ -37,13 +37,13 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
version: ['3.8', '3.11']
version: ["3.8", "3.11"]
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v4
with:
python-version: ${{ matrix.version }}
cache: 'pip'
cache: "pip"
- name: Install dependencies
run: |
python -m pip install --upgrade pip
Expand Down Expand Up @@ -72,7 +72,7 @@ jobs:
uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python-version }}
cache: 'pip'
cache: "pip"

- name: Install dependencies
run: |
Expand Down Expand Up @@ -138,4 +138,16 @@ jobs:
pip install -e ".[dev]"
- name: Build
run: mkdocs build
run: |
mkdocs build
- name: Look for Warnings
run: |
mkdocs build 2>&1 | tee doc-build.log
if grep -q "WARNING" doc-build.log; then
echo $(grep "WARNING" doc-build.log)
echo "::error::Documentation build completed with warnings"
exit 1
else
echo "Documentation build completed successfully"
fi
2 changes: 0 additions & 2 deletions docs/sdk/issue.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
# Issue module

::: kili.presentation.client.issue.IssueClientMethods
::: kili.entrypoints.queries.issue.__init__.QueriesIssue
::: kili.entrypoints.mutations.issue.__init__.MutationsIssue
2 changes: 0 additions & 2 deletions docs/sdk/project.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,4 @@

::: kili.presentation.client.project.ProjectClientMethods

::: kili.entrypoints.queries.project.__init__.QueriesProject

::: kili.entrypoints.mutations.project.__init__.MutationsProject
4 changes: 3 additions & 1 deletion src/kili/entrypoints/mutations/asset/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,9 @@ def append_many_to_dataset(
Example for one asset: `json_metadata_array = [{'imageUrl': '','text': '','url': ''}]`.
- For VIDEO projects (and not VIDEO_LEGACY), you can specify a value with key 'processingParameters' to specify the sampling rate (default: 30).
Example for one asset: `json_metadata_array = [{'processingParameters': {'framesPlayedPerSecond': 10}}]`.
- For Image projects, if you work with geotiff, you can specify a value with key 'processingParameters' to specify the minimum and maximum zoom level.
- In Image projects with geoTIFF assets, you can specify the `minZoom` and `maxZoom` values for the `processingParameters` key.
The `minZoom` parameter defines the zoom level that users are not allowed to zoom out from.
The `maxZoom` value affects asset generation: the higher the value, the greater the level of details and the size of the asset.
Example for one asset: `json_metadata_array = [{'processingParameters': {'minZoom': 17, 'maxZoom': 19}}]`.
disable_tqdm: If `True`, the progress bar will be disabled
wait_until_availability: If `True`, the function will return once the assets are fully imported in Kili.
Expand Down

0 comments on commit ac650a8

Please sign in to comment.