[BUGFIX] Fix getStructureDepth() to match its documentation (#1379)

Co-authored-by: Sebastian Meyer <[email protected]>
kitodo · Dec 16, 2024 · 73aa654 · 73aa654
1 parent 225bbfa
commit 73aa654
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/Classes/Common/MetsDocument.php b/Classes/Common/MetsDocument.php
@@ -1137,9 +1137,9 @@ public function getStructureDepth(string $logId)
         $ancestors = $this->mets->xpath('./mets:structMap[@TYPE="LOGICAL"]//mets:div[@ID="' . $logId . '"]/ancestor::*');
         if (!empty($ancestors)) {
             return count($ancestors);
-        } else {
-            return 0;
         }
+
+        return false;
     }
 
     /**

diff --git a/Tests/Functional/Common/MetsDocumentTest.php b/Tests/Functional/Common/MetsDocumentTest.php
@@ -242,6 +242,6 @@ public function canGetStructureDepth()
         self::assertEquals(3, $correct);
 
         $incorrect = $doc->getStructureDepth('ID_DOES_NOT_EXIST');
-        self::assertEquals(0, $incorrect);
+        self::assertFalse($incorrect);
     }
 }