Skip to content

Commit

Permalink
[MAINTENANCE] Remove paramater from the magic get function (#1412)
Browse files Browse the repository at this point in the history
  • Loading branch information
beatrycze-volk authored Dec 19, 2024
1 parent c7c7839 commit 7f30972
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 9 deletions.
4 changes: 1 addition & 3 deletions Classes/Common/AbstractDocument.php
Original file line number Diff line number Diff line change
Expand Up @@ -452,11 +452,9 @@ abstract protected function magicGetSmLinks(): array;
*
* @abstract
*
* @param bool $forceReload Force reloading the thumbnail instead of returning the cached value
*
* @return string The document's thumbnail location
*/
abstract protected function magicGetThumbnail(bool $forceReload = false): string;
abstract protected function magicGetThumbnail(): string;

/**
* This returns the ID of the toplevel logical structure node
Expand Down
2 changes: 1 addition & 1 deletion Classes/Common/IiifManifest.php
Original file line number Diff line number Diff line change
Expand Up @@ -838,7 +838,7 @@ protected function ensureHasFulltextIsSet(): void
/**
* @see AbstractDocument::magicGetThumbnail()
*/
protected function magicGetThumbnail(bool $forceReload = false): string
protected function magicGetThumbnail(): string
{
return $this->iiif->getThumbnailUrl();
}
Expand Down
7 changes: 2 additions & 5 deletions Classes/Common/MetsDocument.php
Original file line number Diff line number Diff line change
Expand Up @@ -1554,12 +1554,9 @@ protected function magicGetSmLinks(): array
/**
* @see AbstractDocument::magicGetThumbnail()
*/
protected function magicGetThumbnail(bool $forceReload = false): string
protected function magicGetThumbnail(): string
{
if (
!$this->thumbnailLoaded
|| $forceReload
) {
if (!$this->thumbnailLoaded) {
// Retain current PID.
$cPid = $this->cPid ?: $this->pid;
if (!$cPid) {
Expand Down

0 comments on commit 7f30972

Please sign in to comment.