[BUGFIX] re-introduce search for coordinates in ol.Feature Array #1434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrite displayHighlightWord to represent overwritable forward-function to utility.js
| * @see dlfUtils.searchFeatureCollectionForWords | ||
| */ | ||
| dlfViewer.prototype.searchFeatures = function(stringFeatures, value) { | ||
| return dlfUtils.searchFeatureCollectionForWords(stringFeatures, value); |
There was a problem hiding this comment.
But is not in this case the function searchFeatureCollectionForCoordinates unused? Or is the ddb-zeitunsportal using it?
There was a problem hiding this comment.
Yes, in this case I override searchFeatures() in ddb-zeitunsportal with searchFeatureCollectionForCoordinates()
So i don't have to override and maintain the whole displayHighlightWord() function.
| .done(function (fulltextData, fulltextDataImageTwo) { | ||
| var stringFeatures = []; | ||
| .done((fulltextData, fulltextDataImageTwo) => { | ||
| const stringFeatures = []; |
There was a problem hiding this comment.
Can stringFeatures be changed in line Array.prototype.push.apply(stringFeatures, data.getStringFeatures()); after they have been defined as const here?
There was a problem hiding this comment.
Yes, the push() method will work in this case. It still can change the content of the array.
beatrycze-volk
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite displayHighlightWord to represent overwritable forward-function to utility.js
fixes: slub#20