[BUGFIX] Fix fulltext pages to include facets from all associated metadata sections #1441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Previously, full-text pages only indexed facets from the top-level element (e.g., Type: Monograph, Volume), which meant that additional metadata in other metadata sections were not utilized, even though pages were explicitly associated with these through the StructLink/structMap-Logical. Basically all extensive efforts made in Kitodo.Production to structure the document internally (apart from the bibliographic record) were not even used on the page-level.
Solution: This PR extends the indexing to include facets from all DMD sections associated with the page through the StructLink and StructMap-Logical as well as the corresponding (structure) type. As a result, full-text hits can now be filtered down to more granular structural elements they have been associated with (Table, Illustration, Article, Index, Entry, etc.). Additionally, any deeper metadata beneath the top-level element (bibliographic record) is now included in the indexing process as well, expanding the possibilities to filter fulltext-results further - e.g. filtering for Authors of journal-articles instead of only the editor/publisher of a journal.