-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] Tiny refactoring of metadata handling with subentries #1478
Conversation
…, remove metadata with empty value
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1478 +/- ##
============================
============================
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you test this with hierarchical as well as non-hierarchical metadata mappings?
Maybe I am confused, but as far as I understand, metadata values are always handled as arrays internally (because even non-hierarchical metadata fields can be multi-valued), so trying to distinguish hierarchical and non-hierarchical metadata by simply checking for data type "array" is not enough.
So, can you please confirm that this works for non-hierarchical, hierarchical, and multi-valued metadata fields?
Scratch that! I just saw that you check for arrays inside the array of metadata values. My bad! |
Fixes #1308