Switch to SXSSFWorkbook

kitodo · Jan 23, 2025 · 26b2215 · 26b2215
1 parent 11b91f9
commit 26b2215
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/Kitodo/src/main/java/org/kitodo/production/helper/SearchResultGeneration.java b/Kitodo/src/main/java/org/kitodo/production/helper/SearchResultGeneration.java
@@ -18,7 +18,7 @@
 import org.apache.logging.log4j.Logger;
 import org.apache.poi.ss.usermodel.Row;
 import org.apache.poi.ss.usermodel.Sheet;
-import org.apache.poi.xssf.usermodel.XSSFWorkbook;
+import org.apache.poi.xssf.streaming.SXSSFWorkbook;
 import org.kitodo.data.elasticsearch.index.type.enums.ProcessTypeField;
 import org.kitodo.data.exceptions.DataException;
 import org.kitodo.production.dto.ProcessDTO;
@@ -56,7 +56,7 @@ public SearchResultGeneration(String filter, boolean showClosedProcesses, boolea
      *
      * @return HSSFWorkbook
      */
-    public XSSFWorkbook getResult() {
+    public SXSSFWorkbook getResult() {
         return getWorkbook();
     }
 
@@ -96,8 +96,8 @@ public BoolQueryBuilder getQueryForFilter(ObjectType objectType) {
         return query;
     }
 
-    private XSSFWorkbook getWorkbook() {
-        XSSFWorkbook workbook = new XSSFWorkbook();
+    private SXSSFWorkbook getWorkbook() {
+        SXSSFWorkbook workbook = new SXSSFWorkbook();
         Sheet sheet = workbook.createSheet("Search results");
 
         Row title = sheet.createRow(0);

diff --git a/Kitodo/src/main/java/org/kitodo/production/services/data/ProcessService.java b/Kitodo/src/main/java/org/kitodo/production/services/data/ProcessService.java
@@ -82,7 +82,7 @@
 import org.apache.poi.ss.usermodel.DataFormatter;
 import org.apache.poi.ss.usermodel.Row;
 import org.apache.poi.ss.usermodel.Sheet;
-import org.apache.poi.xssf.usermodel.XSSFWorkbook;
+import org.apache.poi.xssf.streaming.SXSSFWorkbook;
 import org.json.JSONArray;
 import org.json.JSONObject;
 import org.json.XML;
@@ -1559,7 +1559,7 @@ public void generateResultAsPdf(String filter, boolean showClosedProcesses, bool
             try (OutputStream out = response.getResponseOutputStream()) {
                 SearchResultGeneration sr = new SearchResultGeneration(filter, showClosedProcesses,
                         showInactiveProjects);
-                XSSFWorkbook wb = sr.getResult();
+                SXSSFWorkbook wb = sr.getResult();
                 List<List<Cell>> rowList = new ArrayList<>();
                 Sheet mySheet = wb.getSheetAt(0);
                 Iterator<Row> rowIter = mySheet.rowIterator();
@@ -1585,6 +1585,7 @@ public void generateResultAsPdf(String filter, boolean showClosedProcesses, bool
                 }
 
                 document.close();
+                wb.close();
                 out.flush();
                 facesContext.responseComplete();
             }
@@ -1605,8 +1606,9 @@ public void generateResult(String filter, boolean showClosedProcesses, boolean s
             try (OutputStream out = response.getResponseOutputStream()) {
                 SearchResultGeneration sr = new SearchResultGeneration(filter, showClosedProcesses,
                         showInactiveProjects);
-                XSSFWorkbook wb = sr.getResult();
+                SXSSFWorkbook wb = sr.getResult();
                 wb.write(out);
+                wb.close();
                 out.flush();
                 facesContext.responseComplete();
             }