TASK: Try to pass one ContentGraphTableNames instance along instead…
#3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of magic strings in some places we still use the old and new way.
…GraphProjection`
bwaidelich
approved these changes
May 10, 2024
Comment on lines
+57
to
+59
| return ContentGraphTableNames::create( | ||
| $this->currentContentRepository->id | ||
| ); | ||
| )->tableNamePrefix; |
There was a problem hiding this comment.
(why) is this method still needed if we don't work with the table name prefixes any longer?
There was a problem hiding this comment.
it is not if we fully rewrite this.
kitsunet
approved these changes
May 10, 2024
kitsunet
merged commit 4f77596
into
kitsunet:feature/content-graph-bound
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… of magic strings
in some places we still use the old and new way.
see neos#5028 (comment)
Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions