Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase http clients' max_clients to 100 #133

Open
wants to merge 1 commit into
base: pyup-initial-update
Choose a base branch
from

Conversation

j3k0
Copy link
Contributor

@j3k0 j3k0 commented Nov 1, 2016

When some HTTP requests take too long, the queue of requests gets filled up and other requests, that shouldn't fail, fail too with timeouts / too long to process errors.

Logs showed errors like this: [simple_httpclient:137:fetch_impl] max_clients limit reached

So it seems I fell into this case: http://stackoverflow.com/questions/33411493/max-clients-limit-reached-request-queued-tornado

This is a simple (naive?) attempt to fix those errors (based on the stackoverflow answer). Increasing the max number of concurrent requests being processed by tornado seems to fix my problems, on my setup.

When some HTTP requests take too long, the queue of request gets filled
up and other requests fail with timeouts / too lon to process errors.

This is a simple (naive?) attempt to fix those errors, by increasing the
max number of concurrent requests being processed.
@garrettheel
Copy link
Collaborator

Thanks for contributing, @j3k0! Would you mind making this a configuration option and only explicitly setting the max number of connections if it is set?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants