Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor for django #186

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

refactor for django #186

wants to merge 3 commits into from

Conversation

codedoga
Copy link

@codedoga codedoga commented Oct 13, 2022

  • rearange imports
  • use CBV
  • no need to decode request body as it's not decoded in other framework tests as well
  • PUT method kwargs can be used directly in response dict (kwargs cannot be anything else beside what's defined in urlpattern)
  • used django 4.1
  • removed unused imports

Django should not use cold start when running benchmarks (as it's also never used in PROD apps)

@codedoga codedoga marked this pull request as ready for review October 13, 2022 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant