def closeBrowser(self) use .quit() instead of .close()

[jdeath]

Using .close() in def closeBrowser(self) caused a crash when restarting the session in mobile browser mode in my docker container. Changing to .quit(), which is also used in def getChromeVersion(self) allowed the mobile mode to start out. I tested in non-docker and it did not cause an issue

[cal4]

For me, if I quit rather than close, there's orphaned Chrome processes

[jdeath]

Darn! I did not check that. But in the docker it definitely crashes. I think I tried .close() in both closeBrowser and getChromeVersion and that still crashed. I'll double check. I might just need to keep a patch going for my use case, which is less than ideal. This thing is so cooll!!

[cal4]

Yeah, I could be wrong so definitely worth a double-check.

From what I can tell, undetected_chromedriver's Chrome overrides the parents quit and exit, while close isn't.

See ultrafunkamsterdam/undetected-chromedriver#1708, ultrafunkamsterdam/undetected-chromedriver#1667 and ultrafunkamsterdam/undetected-chromedriver#1507 (probably more).

[jdeath]

ok. Someone else just posted a PR with a close, then quit and removed some extra closes. I will try that when my day resets.

edit: close then quit caused a crash.

[jdeath]

Closing. I can patch my instance to use .quit() versus .close()