-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix stalling on 'Writing password...' #42
Conversation
Thanks, that fix the problem for me when use -v argument. |
@n4n15 yeah it still sometimes hangs on this step when I don't use the -v argument, for some reason especially so if do use the -d argument. I'll keep investigating but it seems like a completely different issue than the one this solves. |
Is it possible that that it doesnt choose keep me logged in with that one? At least thats my issue atm, but I also changed something else in there, so maybe its not of this code. |
@SgtSobieski I think you're right. I'm pretty sure the issue has something to do with the call to |
So you are thinking the discord flag is causing issue or am I not reading that correctly? I can't reproduce it so I am not sure as to what issue you are having BUT if this fixes one issue without causing another then I see no reason as to why it can't be merged. Line 81 is for accounts locked - not sure how it plays into anything else but again if someone has a better idea then make a PR for it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works as intended
Yeah it's a completely separate issue than the one this PR fixes. I don't know for sure how/why/if this other issue is actually being caused by the discord flag but on my machine it does seem to be correlated. Unlike the issue this PR fixes, it is almost always fixed by killing and rerunning the script. I may do some more research into it and create another PR if I figure it out. In any case, it is again separate from this issue and is no reason not to have merged the change. |
-Added support for
https://rewards.bing.com/
hostname to prevent stalling inexecute_login
function.-Replaced subsequent
self.utils.waitUntilVisible
call withtime.sleep(10)
to prevent timeout error when visiting new hostname.-Changes should fix stalling on 'Writing password...' stage.