Punch fix #63
Merged
Punch fix #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's my first pull request, and I'm not sure why it shows that I changed 3 files. I only made modifications to the file src/punchCards.py. |
|
@vitox013 the branch you're trying to merge is outdated. As in it isn't up-to-date with the main repository. Inside your directory you can run |
Fixed a bug that was preventing the execution of punch cards, as the <a /> tag was identified, but an error occurred when attempting to click: "element not interactable: element has zero size." Therefore, I modified the child element of the <a /> tag to be clicked instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug that prevented punch cards from being completed (it would only enter the screen and immediately exit without clicking on the challenges). The issue was with the line
self.webdriver.find_element(By.CLASS_NAME, "offer-cta").click()since it was not clickable due to its height and width being 0, causing an error when attempting to click: "element not interactable: element has zero size." Sometimes the execution would continue, and other times it would break. Therefore, I modified the child element of the tag to be clicked instead.