-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): replace dependency eslint-plugin-node with eslint-plugin-n ^14.0.0 #1648
base: dev
Are you sure you want to change the base?
Conversation
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the WalkthroughA modification has been made to the ESLint configuration by replacing Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for kleros-v2-university ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for kleros-v2-neo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for kleros-v2-testnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
f14dcda
to
433dcb8
Compare
0546eb2
to
a1cd487
Compare
824fc17
to
e7a92f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
eslint-config/package.json (1)
14-14
: Ensure proper configuration ofeslint-plugin-n
in ESLint configuration files.The replacement of
eslint-plugin-node
witheslint-plugin-n
version^14.0.0
is present ineslint-config/package.json
andyarn.lock
. However, there is no evidence ofeslint-plugin-n
being configured in any ESLint configuration files. Please verify and update the ESLint configuration files to includeeslint-plugin-n
.
eslint-config/package.json
yarn.lock
Analysis chain
LGTM! Verify the installation and configuration of
eslint-plugin-n
.The replacement of
eslint-plugin-node
witheslint-plugin-n
version^14.0.0
is approved.Ensure that the new plugin is correctly installed and configured to maintain linting capabilities.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the installation and configuration of `eslint-plugin-n`. # Test: Check if `eslint-plugin-n` is installed. Expect: The package should be listed. npm list eslint-plugin-n # Test: Check if `.eslintrc.js` contains the configuration for `eslint-plugin-n`. Expect: The configuration should be present. rg --type js 'eslint-plugin-n' .eslintrc.jsLength of output: 194
Script:
#!/bin/bash # Description: Search for ESLint configuration files and check for `eslint-plugin-n` configuration. # Find all potential ESLint configuration files in the repository. fd -e js -e json -e yaml -e yml -e cjs -e mjs -e ts -e coffee --regex 'eslint' # Check if any of these files contain the configuration for `eslint-plugin-n`. fd -e js -e json -e yaml -e yml -e cjs -e mjs -e ts -e coffee --regex 'eslint' --exec rg 'eslint-plugin-n' {}Length of output: 188
Script:
#!/bin/bash # Description: Search all files in the repository for `eslint-plugin-n` configuration. # Check if any files in the repository contain the configuration for `eslint-plugin-n`. rg 'eslint-plugin-n'Length of output: 262
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
yarn.lock
is excluded by!**/yarn.lock
,!**/*.lock
Files selected for processing (1)
- eslint-config/package.json (1 hunks)
6441627
to
444d4c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
yarn.lock
is excluded by!**/yarn.lock
,!**/*.lock
Files selected for processing (1)
- eslint-config/package.json (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- eslint-config/package.json
444d4c2
to
f40ae42
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
yarn.lock
is excluded by!**/yarn.lock
,!**/*.lock
Files selected for processing (1)
- eslint-config/package.json (1 hunks)
Files skipped from review due to trivial changes (1)
- eslint-config/package.json
f40ae42
to
e3392d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
yarn.lock
is excluded by!**/yarn.lock
,!**/*.lock
Files selected for processing (1)
- eslint-config/package.json (1 hunks)
Files skipped from review due to trivial changes (1)
- eslint-config/package.json
e3392d8
to
2fffb97
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
yarn.lock
is excluded by!**/yarn.lock
,!**/*.lock
Files selected for processing (1)
- eslint-config/package.json (1 hunks)
Files skipped from review due to trivial changes (1)
- eslint-config/package.json
2fffb97
to
04a6b46
Compare
2158264
to
669ab93
Compare
fea283d
to
4dbf2f7
Compare
4dbf2f7
to
d112d3d
Compare
d112d3d
to
3e58abf
Compare
Code Climate has analyzed commit 3e58abf and detected 0 issues on this pull request. View more on Code Climate. |
Quality Gate passedIssues Measures |
This PR contains the following updates:
^11.1.0
->^14.0.0
This is a special PR that replaces
eslint-plugin-node
with the community suggested minimal stable replacement version.Configuration
📅 Schedule: Branch creation - "* 0-3 * * *" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.
PR-Codex overview
This PR updates several dependencies in the
eslint-config
package, specifically replacingeslint-plugin-node
witheslint-plugin-n
, and upgrading the version ofeslint-plugin-es
andeslint-utils
. Additionally, it introduces a new dependencyis-core-module
.Detailed summary
eslint-plugin-node
witheslint-plugin-n
(version updated to14.0.0
).eslint-plugin-es
from3.0.0
to4.1.0
.eslint-utils
from2.0.0
to3.0.0
.is-core-module
(version2.16.1
).eslint
peer dependency requirement from>=5.16.0
to>=7.0.0
.