Add FLAC support #111
Open
Add FLAC support #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Small comment to mention that I have tested this (with a non-free account) and it works for me ! thanks a lot ! |
|
sorry for not taking care :( |
|
I'm not sure I understand. |
|
yea, thanks for the PR. I just need some time for this. |
|
it seems that for me, I can only download 128kbps not 320 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've used this to download a couple of playlists and it seems to work so far (using the free trial).
It'd be good if someone could test that it doesn't break operation with free accounts since i don't currently have one.
I've yet to observe any songs with AAC as an option so the change to the "exists already" check doesn't handle that yet.
I'm not sure how robust the error handling is if the server returns results in an unexpected format.
The web client gets media urls with a seperate API call using TRACK_TOKEN from the song data, the encryption on FLACs seems unchanged.
Some songs have a "Fallback" to a different ID and do not allow downloads using the original id, this is currently handled after failing on the original file but it might be worth not trying the original if a fallback is supplied.