Remove the pistar-reconnect script, and place calls in py script
#3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 2, 2022 09:04
the WiFi reconnect routines into the main `pistar-remote` python program, as per Andy's feedback on the original PR (which makes sense): <AndyTaylorTweet#53 (comment)> All `os.system()` calls are consitent with the existing `pistar-remote` calls (e.g. remounting root filesystm [...only, no need to RW the boot part.]).
…ote` key-value pairs into `/etc/pistar-remote` for `KN2TOD`'s improvements.
|
I purposely put the commands in a bash script external to the python program that invokes it so that adjustments could be made to the steps involved as the need arises. More error/retry logic might need to be added as it gets tested, for instance. And the external script file is a perfect mechanism (hook) to add (test) additional DMR command-triggered processes/events - like rewriting TG rules or logging messages or interacting with APRS - all without stopping/restarting the service task that other functions (commands) might depend on in the meanwhile. Flexibility in implementation, eh? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
pistar-reconnectshell script, and places the WiFi reconnect routines into the mainpistar-remotepython program, as per Andy's feedback on the original PR (which makes sense): AndyTaylorTweet#53 (comment)All
os.system()calls are consitent with the existingpistar-remotecalls (e.g. remounting root filesystm [...only, no need to RW the boot part.]).