fix: favicon markup #2115
Merged
fix: favicon markup #2115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Removed
rel="shortcut"becauseCorrected media type for PNG favicons.
Nice to have
For a custom favicon we currently always set
type="image/x-icon"which is a media type for ICO files.Instead, I'd like to change the template to infer the media type from the actually provided file's extension, but I think this is impossible with only the functions built into the html/template package and we'd have to first define suitable string manipulation functions (like exposing
strings.Splitor justfilepath.Ext) viatemplate.FuncMap.If you'd welcome this and provide me some guidance on where exactly I'd need to add this, I'd be happy to extend this PR accordingly or submit another one.