Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2114 - Fix issue of wrong platform used during docker build #2123

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

lmmendes
Copy link
Contributor

@lmmendes lmmendes commented Oct 29, 2024

Context

Removed --platform=$BUILDPLATFORM from the Dockerfile this was overriding the buildx configuration set by goreleaser.yaml .

Testing

Assuming that a new release was created, and published to DockerHub and the following commands are run on a Arm64 machine:

$ docker run -ti --rm --entrypoint /bin/sh knadh/listmonk:latest
$ apk add file
$ file /bin/busybox
/bin/busybox: ELF 64-bit LSB pie executable, ARM aarch64, version 1 (SYSV), dynamically linked, interpreter /lib/ld-musl-aarch64.so.1, BuildID[sha1]=0473dd0398a4d4c4f29ebed5a94f63d78096563e, stripped

The output of the file /bin/busybox should include ARM aarch64 meaning that the base image is Arm64.

@lmmendes lmmendes force-pushed the bugfix/2114-arm64-busybox branch from eaf9914 to 4898a8d Compare October 29, 2024 19:17
@knadh knadh merged commit 2c02e01 into knadh:master Oct 30, 2024
@lmmendes lmmendes deleted the bugfix/2114-arm64-busybox branch October 30, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants