adding a bit of https port for deployment/service of the IntegrationSink

Signed-off-by: Matthias Wessendorf <[email protected]>
knative · Dec 13, 2024 · 3dd433f · 3dd433f
1 parent 8f0b74d
commit 3dd433f
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 11 deletions.
diff --git a/pkg/reconciler/integration/sink/integrationsink_test.go b/pkg/reconciler/integration/sink/integrationsink_test.go
@@ -152,7 +152,6 @@ func TestReconcile(t *testing.T) {
 			serviceLister:     listers.GetServiceLister(),
 			secretLister:      listers.GetSecretLister(),
 			eventPolicyLister: listers.GetEventPolicyLister(),
-			systemNamespace:   testNS,
 		}
 
 		return integrationsink.NewReconciler(ctx, logging.FromContext(ctx), fakeeventingclient.Get(ctx), listers.GetIntegrationSinkLister(), controller.GetEventRecorder(ctx), r)
@@ -205,11 +204,18 @@ func makeDeployment(sink *sinksv1alpha1.IntegrationSink, ready *corev1.Condition
 							Name:            "sink",
 							Image:           "gcr.io/knative-nightly/log-sink:latest",
 							ImagePullPolicy: corev1.PullIfNotPresent,
-							Ports: []corev1.ContainerPort{{
-								ContainerPort: 8080,
-								Protocol:      corev1.ProtocolTCP,
-								Name:          "http",
-							}},
+							Ports: []corev1.ContainerPort{
+								{
+									ContainerPort: 8080,
+									Protocol:      corev1.ProtocolTCP,
+									Name:          "http",
+								},
+								{
+									ContainerPort: 8443,
+									Protocol:      corev1.ProtocolTCP,
+									Name:          "https",
+								},
+							},
 							Env: []corev1.EnvVar{
 								{
 									Name:  "CAMEL_KAMELET_LOG_SINK_LEVEL",
@@ -295,6 +301,12 @@ func makeService(name, namespace string) *corev1.Service {
 					Port:       80,
 					TargetPort: intstr.IntOrString{IntVal: 8080},
 				},
+				{
+					Name:       "https",
+					Protocol:   corev1.ProtocolTCP,
+					Port:       443,
+					TargetPort: intstr.IntOrString{IntVal: 8443},
+				},
 			},
 			Selector: integration.Labels(sinkName),
 		},

diff --git a/pkg/reconciler/integration/sink/resources/container_image.go b/pkg/reconciler/integration/sink/resources/container_image.go
@@ -63,11 +63,17 @@ func MakeDeploymentSpec(sink *v1alpha1.IntegrationSink) *appsv1.Deployment {
 							Name:            "sink",
 							Image:           selectImage(sink),
 							ImagePullPolicy: corev1.PullIfNotPresent,
-							Ports: []corev1.ContainerPort{{
-								ContainerPort: 8080,
-								Protocol:      corev1.ProtocolTCP,
-								Name:          "http",
-							}},
+							Ports: []corev1.ContainerPort{
+								{
+									ContainerPort: 8080,
+									Protocol:      corev1.ProtocolTCP,
+									Name:          "http",
+								},
+								{
+									ContainerPort: 8443,
+									Protocol:      corev1.ProtocolTCP,
+									Name:          "https",
+								}},
 							Env: makeEnv(sink),
 						},
 					},
@@ -102,6 +108,12 @@ func MakeService(sink *v1alpha1.IntegrationSink) *corev1.Service {
 					Port:       80,
 					TargetPort: intstr.IntOrString{IntVal: 8080},
 				},
+				{
+					Name:       "https",
+					Protocol:   corev1.ProtocolTCP,
+					Port:       443,
+					TargetPort: intstr.IntOrString{IntVal: 443},
+				},
 			},
 		},
 	}