Change JobSink execution mode variable to K_EXECUTION_MODE (#8350)

* Change JobSink execution mode variable to `K_EXECUTION_MODE` Align to `K_SINK`. Signed-off-by: Pierangelo Di Pilato <[email protected]> * Fix tests Signed-off-by: Pierangelo Di Pilato <[email protected]> --------- Signed-off-by: Pierangelo Di Pilato <[email protected]>
knative · Nov 28, 2024 · 545c14c · 545c14c
1 parent 91f1c79
commit 545c14c
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/pkg/apis/sinks/v1alpha1/job_sink_defaults_test.go b/pkg/apis/sinks/v1alpha1/job_sink_defaults_test.go
@@ -50,7 +50,7 @@ func TestSetDefaults(t *testing.T) {
 											Name:  "cnt3",
 											Image: "img3",
 											Env: []corev1.EnvVar{
-												{Name: "KNATIVE_EXECUTION_MODE", Value: "something"},
+												{Name: "K_EXECUTION_MODE", Value: "something"},
 											},
 										},
 									},
@@ -63,7 +63,7 @@ func TestSetDefaults(t *testing.T) {
 											Name:  "cnt-ini2",
 											Image: "img-ini2",
 											Env: []corev1.EnvVar{
-												{Name: "KNATIVE_EXECUTION_MODE", Value: "something"},
+												{Name: "K_EXECUTION_MODE", Value: "something"},
 											},
 										},
 									},
@@ -84,14 +84,14 @@ func TestSetDefaults(t *testing.T) {
 											Name:  "cnt",
 											Image: "img",
 											Env: []corev1.EnvVar{
-												{Name: "KNATIVE_EXECUTION_MODE", Value: "batch"},
+												{Name: "K_EXECUTION_MODE", Value: "batch"},
 											},
 										},
 										{
 											Name:  "cnt-ini2",
 											Image: "img-ini2",
 											Env: []corev1.EnvVar{
-												{Name: "KNATIVE_EXECUTION_MODE", Value: "something"},
+												{Name: "K_EXECUTION_MODE", Value: "something"},
 											},
 										},
 									},
@@ -100,21 +100,21 @@ func TestSetDefaults(t *testing.T) {
 											Name:  "cnt",
 											Image: "img",
 											Env: []corev1.EnvVar{
-												{Name: "KNATIVE_EXECUTION_MODE", Value: "batch"},
+												{Name: "K_EXECUTION_MODE", Value: "batch"},
 											},
 										},
 										{
 											Name:  "cnt2",
 											Image: "img2",
 											Env: []corev1.EnvVar{
-												{Name: "KNATIVE_EXECUTION_MODE", Value: "batch"},
+												{Name: "K_EXECUTION_MODE", Value: "batch"},
 											},
 										},
 										{
 											Name:  "cnt3",
 											Image: "img3",
 											Env: []corev1.EnvVar{
-												{Name: "KNATIVE_EXECUTION_MODE", Value: "something"},
+												{Name: "K_EXECUTION_MODE", Value: "something"},
 											},
 										},
 									},

diff --git a/pkg/apis/sinks/v1alpha1/job_sink_types.go b/pkg/apis/sinks/v1alpha1/job_sink_types.go
@@ -29,7 +29,7 @@ import (
 )
 
 const (
-	ExecutionModeEnvVar = "KNATIVE_EXECUTION_MODE"
+	ExecutionModeEnvVar = "K_EXECUTION_MODE"
 )
 
 type ExecutionMode string

diff --git a/pkg/reconciler/jobsink/jobsink_test.go b/pkg/reconciler/jobsink/jobsink_test.go
@@ -264,7 +264,7 @@ func testJob(name string) *batchv1.Job {
 						{
 							Name: "test-container",
 							Env: []corev1.EnvVar{
-								{Name: "KNATIVE_EXECUTION_MODE", Value: "batch"},
+								{Name: "K_EXECUTION_MODE", Value: "batch"},
 							},
 						},
 					},
-Original file line number
+Diff line change
@@ Expand Up / @@ -29,7 +29,7 @@ import ( @@
     )
     const (
-    	ExecutionModeEnvVar = "KNATIVE_EXECUTION_MODE"
+    	ExecutionModeEnvVar = "K_EXECUTION_MODE"
     )
     type ExecutionMode string
@@ Expand Down @@