-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EventType tests verify the type under spec.reference #7888
Conversation
Hi @ctmphuongg. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @Cali0707 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7888 +/- ##
==========================================
- Coverage 69.22% 69.18% -0.04%
==========================================
Files 339 341 +2
Lines 19494 15816 -3678
==========================================
- Hits 13494 10943 -2551
+ Misses 5337 4200 -1137
- Partials 663 673 +10 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ctmphuongg this looks good to me, just one small request: can you run goimports
on the files you changed to fix the formatting error?
@Cali0707 I just fixed the format. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small change (that should fix the tests) and then this should be good to go @ctmphuongg ! Thanks for working on this!
Co-authored-by: Calum Murray <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks @ctmphuongg !
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, ctmphuongg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* test ref * test for reference * format * Update test/rekt/features/apiserversource/data_plane.go Co-authored-by: Calum Murray <[email protected]> * fix syntax --------- Co-authored-by: Calum Murray <[email protected]>
…775) * test ref * test for reference * format * Update test/rekt/features/apiserversource/data_plane.go * fix syntax --------- Co-authored-by: Phuong Cao <[email protected]> Co-authored-by: Calum Murray <[email protected]>
Fixes #7629
Proposed Changes
Add check for EventType Reference in tests