-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register eventshub image for JobSink #8390
Conversation
The package must be registered so that ImageProducer can map it to the right image and replace it in the final yaml.
/cherry-pick release-1.16 |
@mgencur: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8390 +/- ##
=======================================
Coverage 64.22% 64.22%
=======================================
Files 388 388
Lines 23324 23324
=======================================
Hits 14979 14979
Misses 7550 7550
Partials 795 795 ☔ View full report in Codecov by Sentry. |
/test reconciler-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mgencur, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@mgencur: new pull request created: #8391 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The package must be registered so that ImageProducer can map it to the right image and replace it in the final yaml.
So far the JobSink E2E test was passing because another step (which runs in parallel) registered the eventshub package in the same context earlier. However, if the JobSink step runs first it fails to replace the image and the final Yaml includes:
"image": "ko://knative.dev/reconciler-test/cmd/eventshub"
Fixes #
Proposed Changes
Pre-review Checklist
Release Note
Docs