Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register eventshub image for JobSink #8390

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

mgencur
Copy link
Contributor

@mgencur mgencur commented Dec 17, 2024

The package must be registered so that ImageProducer can map it to the right image and replace it in the final yaml.

So far the JobSink E2E test was passing because another step (which runs in parallel) registered the eventshub package in the same context earlier. However, if the JobSink step runs first it fails to replace the image and the final Yaml includes: "image": "ko://knative.dev/reconciler-test/cmd/eventshub"

Fixes #

Proposed Changes

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note


Docs

The package must be registered so that ImageProducer can map it to the
right image and replace it in the final yaml.
@knative-prow knative-prow bot added area/test-and-release Test infrastructure, tests or release size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 17, 2024
@mgencur
Copy link
Contributor Author

mgencur commented Dec 17, 2024

/cherry-pick release-1.16

@knative-prow-robot
Copy link
Contributor

@mgencur: once the present PR merges, I will cherry-pick it on top of release-1.16 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.22%. Comparing base (2f165f1) to head (b3ef9b2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8390   +/-   ##
=======================================
  Coverage   64.22%   64.22%           
=======================================
  Files         388      388           
  Lines       23324    23324           
=======================================
  Hits        14979    14979           
  Misses       7550     7550           
  Partials      795      795           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mgencur
Copy link
Contributor Author

mgencur commented Dec 17, 2024

/test reconciler-tests

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2024
Copy link

knative-prow bot commented Dec 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mgencur, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2024
@knative-prow knative-prow bot merged commit b00da59 into knative:main Dec 17, 2024
35 of 36 checks passed
@knative-prow-robot
Copy link
Contributor

@mgencur: new pull request created: #8391

In response to this:

/cherry-pick release-1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants