-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improving image sizes #39
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you!
These images are processed through Imagine and thumnailed. So the source image is not what we show the user. So I'm genuinely not sure if this affects the final image sizes or not. @Leannapelham were you generally being proactive or did you see a problem with the image sizes on the site? |
Hm, yeah, not sure if updated source image size will affect the final image size after Imagine. Btw, Lighthouse (IIRC) suggests using the new Webp format for images as that one has even better size with the same quality. And I see Imagine in theory should support it as well: https://github.com/liip/LiipImagineBundle/blob/2.x/Resources/doc/basic-usage.rst#webp-image-format I wonder if we should move to that format instead? |
Hmm, what about 2 things:
|
That would simplify things with blog... I think we kinda overcomplicated it now. I wonder if we should add hash to the image filenames to allow us to cache them forever? Also wonder if that Polish (🇵🇱?) thing would require to be paid extra. |
ran all the blog images through an optimizer to improve image size