Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aria required children #38

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Aria required children #38

wants to merge 4 commits into from

Conversation

koddsson
Copy link
Owner

There's something broken here. Not sure what it is but might be a silent failure from Web Test Runner when it's not able to clean up the fixture (for whatever reason).

@koddsson
Copy link
Owner Author

Locally the tests pass but only like 1 of the aria-requried-children tests are actually run.

Copy link

LCOV of commit 5fdfd73 during CI #130

	(use "lcov --ignore-errors deprecated,deprecated ..." to suppress this warning)
Reading tracefile /var/folders/b3/2xm02wpd21qgrpkck5q1c6k40000gn/T/__koddsson_github-actions-report-lcov/lcov.info.
Summary coverage rate:
  source files: 26
  lines.......: 89.7% (1421 of 1585 lines)
  functions...: 90.7% (39 of 43 functions)
  branches....: 92.9% (302 of 325 branches)
Message summary:
  1 warning message:
    deprecated: 1

Files changed coverage rate:
  	(use "lcov --ignore-errors deprecated,deprecated ..." to suppress this warning)
                                     |Lines       |Functions  |Branches    
  Filename                           |Rate     Num|Rate    Num|Rate     Num
  src/rules/aria-required-children.ts|82.7%    127| 100%     1|66.7%      3
  src/scanner.ts                     |70.8%     96|66.7%     3|71.4%      7

⛔ The code coverage is too low. Expected at least 90.

@koddsson
Copy link
Owner Author

Ah! Cool that the coverage check then catches this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant