use request-based RMA sync #52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
correct fix for kokkos#51 related to https://www.mail-archive.com/[email protected]/msg30676.html Signed-off-by: Jeff Hammond <[email protected]>
|
This looks good. Am I correct to assume that the |
|
There reasons why it should be faster and it may be in practice in most cases you care about, but the specification doesn't assume that, and it's possible some implementations will favor flush. Flush is more like SHMEM... |
|
Superseded by #53 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
correct fix for #51
related to https://www.mail-archive.com/[email protected]/msg30676.html
Signed-off-by: Jeff Hammond [email protected]