-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add status message when nvtx connectors are not built #280
base: develop
Are you sure you want to change the base?
Conversation
Signed-off-by: Carl Pearson <[email protected]>
#281 should fix the simple build failure. |
Signed-off-by: Carl Pearson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind adding similar messages for all the other tools?
I assume you mean for all the other third-party library connector tools in Kokkos Tools? It doesn't make sense for the in-house tools in Kokkos Tools, e.g., SpaceTimeStack, right? For this PR, maybe we do just VTune connector, roctx connector, and nvtx connector. I think handling a tool like the APEX Kokkos Tools connector may be slightly more complicated. I see that the roctx connector is handled now too in this PR. |
The ones I noticed missing are |
Got it, that makes sense then - and I think for this PR, it should just be ensured the CMake logic for each of the connectors consistent with each other, as @dalg24 commented. Thanks @cwpearson for looking at this! |
We had a user who wasn't getting the nvtx connector built as expected. This may help clarify what's going on in the future.