Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add status message when nvtx connectors are not built #280

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

cwpearson
Copy link
Contributor

@cwpearson cwpearson commented Jan 16, 2025

We had a user who wasn't getting the nvtx connector built as expected. This may help clarify what's going on in the future.

@cwpearson
Copy link
Contributor Author

cwpearson commented Jan 16, 2025

#281 should fix the simple build failure.

CMakeLists.txt Show resolved Hide resolved
@cwpearson cwpearson requested a review from dalg24 January 17, 2025 16:22
Copy link
Contributor

@masterleinad masterleinad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding similar messages for all the other tools?

@vlkale
Copy link
Contributor

vlkale commented Jan 17, 2025

Would you mind adding similar messages for all the other tools?

I assume you mean for all the other third-party library connector tools in Kokkos Tools? It doesn't make sense for the in-house tools in Kokkos Tools, e.g., SpaceTimeStack, right?

For this PR, maybe we do just VTune connector, roctx connector, and nvtx connector. I think handling a tool like the APEX Kokkos Tools connector may be slightly more complicated.

I see that the roctx connector is handled now too in this PR.

@masterleinad
Copy link
Contributor

The ones I noticed missing are VTune and Variorum since they also don't have a CMake option. It might be a good idea to just have a CMake option for everything but that can clearly be a different pull request.

@vlkale
Copy link
Contributor

vlkale commented Jan 17, 2025

The ones I noticed missing are VTune and Variorum since they also don't have a CMake option. It might be a good idea to just have a CMake option for everything but that can clearly be a different pull request.

Got it, that makes sense then - and I think for this PR, it should just be ensured the CMake logic for each of the connectors consistent with each other, as @dalg24 commented.

Thanks @cwpearson for looking at this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants