Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(STONEINTG-948): migrate redhat-appstudio/clair-in-ci #30

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(STONEINTG-948): migrate redhat-appstudio/clair-in-ci #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .tekton/build_and_trigger.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ spec:
pipeline: "2h"
params:
- name: output-image
value: quay.io/redhat-appstudio/clair-in-ci:to_test
value: quay.io/konflux-ci/clair-in-ci:to_test
- name: builder-image
value: registry.access.redhat.com/ubi9/buildah:9.0.0-19@sha256:c8b1d312815452964885680fc5bc8d99b3bfe9b6961228c71a09c72ca8e915eb
- name: dockerfile
Expand All @@ -24,7 +24,7 @@ spec:
- name: event_type
value: "{{ event_type }}"
- name: registry-url
value: "quay.io/redhat-appstudio"
value: "quay.io/konflux-ci"
- name: registry-username
value: "{{ registry_username }}"
- name: registry-password
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do registry_username and registry_password get sourced?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this gets injected by PaC, but not sure. @jencull or @jsztuka you may know better than me about how this is set up.

Copy link
Collaborator

@jsztuka jsztuka Dec 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you would need to add robot account to the https://quay.io/repository/konflux-ci/clair-in-ci?tab=info.
robot account: konflux-ci+testservice
Hopefully this will get the error away.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Josh-Everett robot user should be added to to writers group then writers group be added to the repo clair-in-ci .

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK Scott added that robot account to the quay repo, but here it is still set to use the old user + pass. I am having trouble figuring out where to set which robot account to use.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we will need some authorization to be able seeing what members in our integration repos
so we can solve such these cases

Expand Down Expand Up @@ -119,7 +119,7 @@ spec:
kind: ClusterTask
params:
- name: IMAGE
value: "quay.io/redhat-appstudio/clair-in-ci:$(tasks.calculate-tag.results.image_tag)"
value: "quay.io/konflux-ci/clair-in-ci:$(tasks.calculate-tag.results.image_tag)"
- name: BUILDER_IMAGE
value: $(params.builder-image)
- name: DOCKERFILE
Expand All @@ -130,13 +130,13 @@ spec:
taskSpec:
steps:
- name: test-clair-version
image: quay.io/redhat-appstudio/clair-in-ci:$(tasks.calculate-tag.results.image_tag)
image: quay.io/konflux-ci/clair-in-ci:$(tasks.calculate-tag.results.image_tag)
script: |
#!/usr/bin/env bash
echo "See current version of Clair below:"
clair-action --version
- name: get-clair-output
image: quay.io/redhat-appstudio/clair-in-ci:$(tasks.calculate-tag.results.image_tag)
image: quay.io/konflux-ci/clair-in-ci:$(tasks.calculate-tag.results.image_tag)
script: |
#!/usr/bin/env bash
echo "Test real life usage of Clair"
Expand Down