Retain a reference to the item in SCItemCell

This ensures that the icon is cached for the right item even when scrolling very fast. This is required because the item reference might have already changed when the icon finishes loading.
koraktor · Jun 15, 2014 · f6bb41a · f6bb41a
1 parent c0ae89d
commit f6bb41a
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/Suitcase/Classes/SCItemCell.m b/Suitcase/Classes/SCItemCell.m
@@ -97,12 +97,13 @@ - (void)loadImage
     }
 
     __weak SCItemCell *weakSelf = self;
+    id <SCItem> item = self.item;
     [self.imageView setImageWithURLRequest:[NSURLRequest requestWithURL:_item.iconUrl]
                           placeholderImage:kPlaceHolderImage
                                    success:^(NSURLRequest *request, NSHTTPURLResponse *response, UIImage *image) {
                                        weakSelf.imageView.image = image;
 
-                                       [SCImageCache cacheIcon:image forItem:weakSelf.item];
+                                       [SCImageCache cacheIcon:image forItem:item];
                                    }
                                    failure:^(NSURLRequest *request, NSHTTPURLResponse *response, NSError *error) {
 #ifdef DEBUG