Update/20240624 #6
Conversation
Update Go dependencies
…mit-action Update stefanzweifel/git-auto-commit-action action
Update release pipeline to only run on merge
Fix release pipeline
Use PAT in release pipeline
Switch to github_output
Signed-off-by: krogon <[email protected]>
…g' into update/20240624
Signed-off-by: krogon <[email protected]>
Signed-off-by: krogon <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| gopkg.in/yaml.v3 v3.0.1 // indirect | ||
| ) | ||
|
|
||
| replace github.com/k-phoen/semver-release-action => github.com/krogon/semver-release-action v1.3.2-0.20210326053057-7d547fe0e0a5 |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
replacement are not allowed: github.com/k-phoen/semver-release-action (gomoddirectives)
| @@ -6,7 +6,7 @@ import ( | |||
| "strconv" | |||
| "strings" | |||
|
|
|||
| version "github.com/blang/semver" | |||
| version "github.com/blang/semver/v4" | |||
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
import 'github.com/blang/semver/v4' is not allowed from list 'Main' (depguard)
| @@ -6,7 +6,7 @@ import ( | |||
|
|
|||
| "github.com/K-Phoen/semver-release-action/internal/pkg/action" | |||
| "github.com/K-Phoen/semver-release-action/internal/pkg/semver" | |||
| "github.com/google/go-github/github" | |||
| "github.com/google/go-github/v45/github" | |||
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
import 'github.com/google/go-github/v45/github' is not allowed from list 'Main' (depguard)
| "strings" | ||
|
|
||
| "github.com/K-Phoen/semver-release-action/internal/pkg/action" | ||
| "github.com/blang/semver" | ||
| "github.com/google/go-github/github" | ||
| "github.com/blang/semver/v4" |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
import 'github.com/blang/semver/v4' is not allowed from list 'Main' (depguard)
| "github.com/blang/semver" | ||
| "github.com/google/go-github/github" | ||
| "github.com/blang/semver/v4" | ||
| "github.com/google/go-github/v45/github" |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
import 'github.com/google/go-github/v45/github' is not allowed from list 'Main' (depguard)
| @@ -6,7 +6,7 @@ import ( | |||
| "strings" | |||
|
|
|||
| "github.com/K-Phoen/semver-release-action/internal/pkg/action" | |||
| "github.com/google/go-github/v28/github" | |||
| "github.com/google/go-github/v45/github" | |||
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
import 'github.com/google/go-github/v45/github' is not allowed from list 'Main' (depguard)
| @@ -33,18 +43,26 @@ | |||
| owner := parts[0] | |||
| repo := parts[1] | |||
|
|
|||
| refs, response, err := client.Git.ListRefs(ctx, owner, repo, &github.ReferenceListOptions{ | |||
| Type: "tag", | |||
| refs, response, err := client.Git.ListMatchingRefs(ctx, owner, repo, &github.ReferenceListOptions{ | |||
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
github.ReferenceListOptions is missing field ListOptions (exhaustruct)
| Use: "latest-tag [REPOSITORY] [GH_TOKEN]", | ||
| Args: cobra.ExactArgs(2), | ||
| Use: "latest-tag [REPOSITORY] [GH_TOKEN] [TAG_FORMAT]", | ||
| Args: cobra.ExactArgs(3), |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
Magic number: 3, in detected (mnd)
| version, err := semver.ParseTolerant(strings.Replace(*ref.Ref, "refs/tags/", "", 1)) | ||
| versionStr := strings.Replace(*ref.Ref, "refs/tags/", "", 1) | ||
| formatValid, _ := regexp.MatchString(tagFormatRegex, versionStr) | ||
| if !formatValid { |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
only one cuddle assignment allowed before if statement (wsl)
| if !formatValid { | ||
| continue | ||
| } | ||
| version, err := semver.ParseTolerant(versionStr) |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
assignments should only be cuddled with other assignments (wsl)
K-Phoen#44