Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Android support #1065

Merged
merged 1 commit into from
Jan 5, 2025
Merged

Add Android support #1065

merged 1 commit into from
Jan 5, 2025

Conversation

marcprux
Copy link
Contributor

@marcprux marcprux commented Jan 5, 2025

Checklist:

  • Correct file headers (see CONTRIBUTING.md).
  • Formatted with SwiftFormat.
  • Tests added.

Changes proposed in this pull request:

@krzyzanowskim krzyzanowskim merged commit 98e2219 into krzyzanowskim:main Jan 5, 2025
2 checks passed
@krzyzanowskim
Copy link
Owner

thank you

@marcprux
Copy link
Contributor Author

marcprux commented Jan 6, 2025

I see this error in the PR checks:

Error
skiptools/swift-android-action@v2 is not allowed to be used in krzyzanowskim/CryptoSwift. Actions in this workflow must be: within a repository owned by krzyzanowskim, created by GitHub, verified in the GitHub Marketplace, or matching the following: actions/*, github/codeql-action/*, maxim-lobanov/*.

...which is odd, since the action is published on the GitHub marketplace and we are a verified organization. Maybe you need to add the action to the allowlist?

@krzyzanowskim
Copy link
Owner

not sure what happens. Added skiptools/* to the list just in case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants