Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: deleteCollectionNamespacedCustomObject to support labelSelector #1976

Merged
merged 4 commits into from
Oct 30, 2024

Conversation

ArpanSolanki29
Copy link

Add support for labelSelector for deleteCollectionNamespacedCustomObject.
This pr is regarding the issue: #1778

Note: Support for fieldSelector can be added once the PR is approved and merged

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 26, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @ArpanSolanki29!

It looks like this is your first PR to kubernetes-client/javascript 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/javascript has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 26, 2024
@mstruebing mstruebing added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 26, 2024
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 26, 2024
@brendandburns
Copy link
Contributor

@ArpanSolanki29 can you try running this github action locally and attach a pointer to the logs/run.

Unfortunately, it's hard to test that changes to a github action actually work before running them.

@brendandburns
Copy link
Contributor

For reference, this is adding in this commit:
kubernetes-client/gen@a608a9d

@ArpanSolanki29
Copy link
Author

Hi @brendandburns, thank you for reviewing the PR!

I've run the generate GitHub action locally, and here are the logs: GitHub Action Logs.

The action confirmed that labelSelector is now accepted as a valid parameter. You can see the updated code section reflecting this: Code Diff Link.

Please let me know if there’s anything more needed—happy to help!

@brendandburns
Copy link
Contributor

/lgtm
/approve

Thanks for verifying!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anandfresh, ArpanSolanki29, brendandburns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2024
@mstruebing mstruebing removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 30, 2024
@mstruebing
Copy link
Member

I've removed the do not merge label as the PR in kubernetes-client/gen is already merged.

@k8s-ci-robot k8s-ci-robot merged commit c803b15 into kubernetes-client:master Oct 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants