-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: deleteCollectionNamespacedCustomObject to support labelSelector #1976
Conversation
Welcome @ArpanSolanki29! |
@ArpanSolanki29 can you try running this github action locally and attach a pointer to the logs/run. Unfortunately, it's hard to test that changes to a github action actually work before running them. |
For reference, this is adding in this commit: |
Hi @brendandburns, thank you for reviewing the PR! I've run the generate GitHub action locally, and here are the logs: GitHub Action Logs. The action confirmed that labelSelector is now accepted as a valid parameter. You can see the updated code section reflecting this: Code Diff Link. Please let me know if there’s anything more needed—happy to help! |
/lgtm Thanks for verifying! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anandfresh, ArpanSolanki29, brendandburns The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I've removed the |
Add support for labelSelector for deleteCollectionNamespacedCustomObject.
This pr is regarding the issue: #1778
Note: Support for fieldSelector can be added once the PR is approved and merged