-
Notifications
You must be signed in to change notification settings - Fork 809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-enable VAC on clusters with beta API version #2114
Auto-enable VAC on clusters with beta API version #2114
Conversation
Signed-off-by: Connor Catlett <[email protected]>
… feature Signed-off-by: Connor Catlett <[email protected]>
Code Coverage DiffThis PR does not change the code coverage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great change, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: torredil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Is this a bug fix or adding new feature?
Feature
What is this PR about? / Why do we need it?
Automatically enable VAC on clusters using the beta API version. This improves the experience for beta users and ensures they do not accidentally create a volume with a VAC bound that was not applied due to the feature gate being disabled.
Also updates the VAC documentation to reflect this, and fix a few minor issues.
What testing is done?
Templating:
Also tested manually on a cluster with and without VAC enabled and observed the desired effect.