Adding RoleArn option for the driver

[sarthakkothari]

Is this a bug fix or adding new feature?
New Feature

What is this PR about? / Why do we need it?
Adds the ability to provide a role to interact with EC2 APIs.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: sarthakkothari / name: sarthakkothari (a3199f4, 8b8f5fb, b0c1f58, 318d065)

[k8s-ci-robot]

Welcome @sarthakkothari!

It looks like this is your first PR to kubernetes-sigs/aws-ebs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-ebs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @sarthakkothari. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign andrewsirenko for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[github-actions]

Code Coverage Diff

File	Old Coverage	New Coverage	Delta
github.com/kubernetes-sigs/aws-ebs-csi-driver/pkg/cloud/cloud.go	88.9%	88.6%	-0.3

[ConnorJC3]

/ok-to-test

[k8s-ci-robot]

@chu-yik: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[wmesard]

This change is adding a fourth method of getting IAM permissions to the driver. So the relevant section of the documentation should be updated.

[sarthakkothari]

@wmesard I've added the details in the options.md file.

What exactly needs to be added in the installation part of the document? The document doesn't seem to go over any details regarding running the controllers outside of the target cluster.

[wmesard]

What exactly needs to be added in the installation part of the document? The document doesn't seem to go over any details regarding running the controllers outside of the target cluster.

My comment was about authZ, not about where the driver is running. And your addition to that document shouldn't mention anything about where the driver is running either, since that is merely one possible use case for the proposed code change. (In other words, this is not a Tachyon-specific change. Leave the Tachyon use-case out of the discussion.)

The section I linked to says:

There are several methods to grant the driver IAM permissions:

• [Using Instance profile]
• [Using EKS service role]
• [Using a K8s secret]

I'm saying you should add a fourth bullet. Something like:

• Specifying a role-arn. In certain deployments, the IAM credentials from one of the three methods above do not, themselves, give the driver the required permissions. Rather they give the driver the ability to Assume an IAM Role which does have those permissions. See Driver Options.

Or something like that.

[torredil]

/hold

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ConnorJC3]

/close

Closing this outdated PR for now

[k8s-ci-robot]

@ConnorJC3: Closed this PR.

In response to this:

/close

Closing this outdated PR for now

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.