-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.35] Fix csi-attacher crash due to VAC feature gate on wrong sidecar #2148
[release-1.35] Fix csi-attacher crash due to VAC feature gate on wrong sidecar #2148
Conversation
Signed-off-by: Connor Catlett <[email protected]>
e0f5396
to
d9aae1f
Compare
Code Coverage Diff
|
/lgtm |
@ElijahQuinones: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: torredil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
All containers come up on 1.31 cluster:
|
Is this a bug fix or adding new feature?
Bug fix
What is this PR about? / Why do we need it?
VAC feature gate is applied to the wrong sidecar (attacher instead of resizer), fix that and push a new Helm release.
What testing is done?
Manual