Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Fix reconcile extensions dashboard #11607

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🌱 Fix reconcile extensions dashboard #11607

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 8 additions & 34 deletions hack/observability/grafana/dashboards/runtime-extensions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
"editable": true,
"fiscalYearStartMonth": 0,
"graphTooltip": 0,
"id": 6,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be kept? (the other dashboards have an id set)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I edited the dashboard in the UX and then saved the json from there, not sure why the ID was dropped

Copy link
Member

@sbueringer sbueringer Dec 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as the dashboard still works on tilt up I'm fine either way.

In general it would be good if we keep exporting dashboards the same way going forward so we don't go back on forth on things like this (IIRC there are various ways to export or save dashboards in Grafana)

(I think the changes in variable values below are a similar case)

"links": [],
"liveNow": false,
"panels": [
Expand Down Expand Up @@ -168,32 +167,7 @@
]
}
},
"overrides": [
{
"__systemRef": "hideSeriesFrom",
"matcher": {
"id": "byNames",
"options": {
"mode": "exclude",
"names": [
"{hook=\"GeneratePatches\"}"
],
"prefix": "All except:",
"readOnly": true
}
},
"properties": [
{
"id": "custom.hideFrom",
"value": {
"legend": false,
"tooltip": false,
"viz": true
}
}
]
}
]
"overrides": []
},
"gridPos": {
"h": 8,
Expand Down Expand Up @@ -226,7 +200,7 @@
"refId": "A"
}
],
"title": "Request per minute",
"title": "Request per seconds",
"type": "timeseries"
},
{
Expand Down Expand Up @@ -331,12 +305,12 @@
"current": {
"selected": true,
"text": [
"GeneratePatches",
"DiscoverVariables"
"DiscoverVariables",
"GeneratePatches"
],
"value": [
"GeneratePatches",
"DiscoverVariables"
"DiscoverVariables",
"GeneratePatches"
]
},
"datasource": {
Expand Down Expand Up @@ -370,6 +344,6 @@
"timezone": "",
"title": "Runtime Extensions",
"uid": "eefe124a-7ad8-488f-8078-ef30f7b2ac21",
"version": 3,
"version": 1,
"weekStart": ""
}
}
Loading