🐛 Machine: sort list of pre-drain hooks for stable condition messages #11624
Conversation
Signed-off-by: Stefan Büringer [email protected]
k8s-ci-robot
added
the
cncf-cla: yes
|
/cherry-pick release-1.9 |
k8s-ci-robot
added
the
size/S
|
@sbueringer: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
sbueringer
added
the
area/machine
|
/test pull-cluster-api-e2e-main |
| @@ -1128,12 +1128,12 @@ func TestDeletingCondition(t *testing.T) { | |||
| }, | |||
| reconcileDeleteExecuted: true, | |||
| deletingReason: clusterv1.MachineDeletingWaitingForPreDrainHookV1Beta2Reason, | |||
| deletingMessage: "Waiting for pre-drain hooks to complete (hooks: test-hook)", | |||
| deletingMessage: "Waiting for pre-drain hooks to succeed (hooks: test-hook)", | |||
There was a problem hiding this comment.
Q:what about adding a test with more than one hook validating that hooks are sorted?
There was a problem hiding this comment.
These tests are not executing the fixed/affected code
(I only updated them because I did a search/replace on the changed condition message)
There was a problem hiding this comment.
We have no code coverage on the pre-drain code path (this PR) or the pre-terminate code path (fixed in the previous PR: #11487).
I can open a follow-up issue if you want, but I wouldn't want to block this PR because of that if possible
|
/lgtm Please open a follow up issue to add testing for hooks sorting |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: b433145ff7a6448b73303fdd71ce9dc0ece7d2ec
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@sbueringer: new pull request created: #11625 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
I think we should add tests for more than just the sorting part. Opened an issue accordingly: #11626 |
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
Follow-up to #11487
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #